Repository navigation
capture_la up to 48 MS/s, pre-trigger and early-stop reporting (gateware v50+) - #59
Merged
Merged
Conversation
No API change: above 12 MS/s the pod captures the changes and replies in the usual form. The SDK and MCP docstrings say so, with the one limit (a signal changing over ~6 million times per second for long ends the capture). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Trigger(la, edge, pre_samples=N): capture_la also returns up to N samples from before the trigger; LaCapture.pre_samples says how many it holds (the trigger's index). - LaCapture.truncated: "busy" or "memory" when a capture above 12 MS/s stopped early and holds fewer samples than asked (logged as a warning). - MCP capture_la: trigger_pre_samples; the result reports pre_samples and truncated. - README, API and tool surface snapshots updated (additive). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…50+) FPGA-timed 4 us pulses on a free LA channel must measure exactly 192 / 96 / 64 samples at 48 / 24 / 16 MS/s, and a pre-trigger capture must return the requested samples before the trigger with the trigger on the rising edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he arm The trigger fired before 2000 samples of history existed (the train started before the capture armed). Now the line is a low GPIO output and a second connection starts the train 100 ms after the arm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wardviaene
changed the title
The MCP's minimum embeddedci (2.13.6) has no Trigger(pre_samples) or LaCapture.pre_samples/truncated: read them with getattr and build a plain Trigger unless a pre-trigger is asked for (then a clear upgrade message). Tested against embeddedci 2.13.6 from PyPI, as the mcp-min-sdk job does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
capture_la(samples, sample_rate_hz)is unchanged. With gateware v50 (benchpod-firmware#91), the pod runs requests above 12 MS/s at 48, 24 or 16 MS/s, records only the changes, and replies in the usual form.Additions (all optional, all backward compatible)
Trigger(la, edge, pre_samples=N):capture_laalso returns up to N samples from before the trigger, at any rate up to 48 MS/s.LaCapture.pre_samplessays how many it holds, and the trigger is at that index.LaCapture.truncated:"busy"or"memory"when a capture above 12 MS/s stopped early and holds fewer samples than asked. This is also logged as a warning.capture_la: a newtrigger_pre_samplesparameter, and the result reportspre_samplesandtruncated.Tests
Triggervalidation.🤖 Generated with Claude Code