Repository navigation
fix: restore runs-on so Deploy workflow can run - #1105
Merged
Merged
Conversation
Jobs lost their runner after the Warp demo cleanup. Pin all jobs to ubuntu-24.04 so Playwright 1.58.1 can install Chromium (ubuntu-latest may resolve to 26.04, which needs Playwright 1.61+). Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jobs have had no
runs-onsince fa637ff removed the Warp demo runners, so the workflow is invalid and starts zero jobs.Pin every job to
ubuntu-24.04. This repo locks Playwright at 1.58.1, which cannot install Chromium on Ubuntu 26.04 (needs 1.61+), andubuntu-latestmay resolve to 26.04.No other Warp-specific config was left in the workflow; only the runner labels were removed.
Note
Low Risk
CI-only runner label fix with no application or deployment command changes.
Reviewed by Cursor Bugbot for commit 6d8c773. Bugbot is set up for automated code reviews on this repo. Configure here.