Repository navigation
Fix async keyword overrides in add_kwargs - #987
Open
laulauraluo wants to merge 1 commit into
Open
laulauraluo wants to merge 1 commit into
laulauraluo wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #974.
Problem
Calling
add_kwargs()with an existing name leaves both injections registered. If the earlier dependency is asynchronous, its completed value can overwrite the replacement. The superseded dependency also still runs.Fix
Merge the existing keyword mapping and reuse
set_kwargs()so each name has one injection. Covers Callable, Factory and Singleton, including call-time overrides and superseded dependency side effects. Related prior proposal: #982; this change is limited to Callable keyword registration.Validation
make test: 441 passed, independently repeated.make check: Flake8, pydocstyle and mypy passed.Tested on macOS/Python 3.12. A local test-runner workaround disabled a broken readline import before collection; provider behavior was not mocked. The full test suite and other platforms were not run.