Skip to content

ci: run code quality checks on Node.js 24 - #2766

Open
nogara wants to merge 1 commit into
evolution-foundation:developfrom
nogara:ci/node-24-code-quality
Open

nogara wants to merge 1 commit into
evolution-foundation:developfrom
nogara:ci/node-24-code-quality

Conversation

@nogara

@nogara nogara commented Oct 23, 2026 •

Copy link
Copy Markdown

Summary

Follow-up to #2761 / #2765.

.github/workflows/check_code_quality.yml still runs lint and build on node-version: 20.x. Node.js 20 is end-of-life. Also, the Dockerfile builds and ships on Node.js 24. CI therefore checks the code against a different major version than the one that runs in production.

This PR changes the workflow to node-version: 24.x. setup-node resolves 24.x to the latest 24 release, so CI also gets the October 2026 security patches (v24.22.1+).

Test plan

  • Check Code Quality workflow passes on this PR (lint, db:generate, build)

🤖 Generated with Claude Code

https://claude.ai/code/session_01CPViW4Kzn5aFydKQgfV3yq

Summary by Sourcery

Align code quality checks with the Node.js version used in production.

Enhancements:

  • Run code quality checks against Node.js 24 to align CI with the production runtime.

CI:

  • Update the code quality workflow to use the latest Node.js 24.x release.

@sourcery-ai

sourcery-ai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The code-quality workflow now runs on the latest available Node.js 24 release, matching the production Dockerfile runtime and ensuring CI validates linting and builds against the supported production major version.

File-Level Changes

Change Details Files
Align the code-quality CI runtime with the Node.js version used by the production Docker image.
  • Update the workflow's setup-node version from Node.js 20.x to 24.x.
  • Retain the existing lint, database generation, build, and dependency-cache workflow steps under the new runtime.
.github/workflows/check_code_quality.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

The lint/build workflow still used Node.js 20.x, which is end-of-life
and no longer matches the runtime: the Dockerfile builds and runs on
Node.js 24. Run CI on 24.x so lint and build are checked against the
same major version that ships.

Refs evolution-foundation#2761

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CPViW4Kzn5aFydKQgfV3yq
@nogara
nogara force-pushed the ci/node-24-code-quality branch from 370bf8e to f590303 Compare October 23, 2026 16:35
@nogara
nogara changed the base branch from main to develop October 23, 2026 16:35

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant