Repository navigation
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe code-quality workflow now runs on the latest available Node.js 24 release, matching the production Dockerfile runtime and ensuring CI validates linting and builds against the supported production major version. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
The lint/build workflow still used Node.js 20.x, which is end-of-life and no longer matches the runtime: the Dockerfile builds and runs on Node.js 24. Run CI on 24.x so lint and build are checked against the same major version that ships. Refs evolution-foundation#2761 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CPViW4Kzn5aFydKQgfV3yq
nogara
force-pushed
the
ci/node-24-code-quality
branch
from
October 23, 2026 16:35
370bf8e to
f590303
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2761 / #2765.
.github/workflows/check_code_quality.ymlstill runs lint and build onnode-version: 20.x. Node.js 20 is end-of-life. Also, the Dockerfile builds and ships on Node.js 24. CI therefore checks the code against a different major version than the one that runs in production.This PR changes the workflow to
node-version: 24.x.setup-noderesolves24.xto the latest 24 release, so CI also gets the October 2026 security patches (v24.22.1+).Test plan
Check Code Qualityworkflow passes on this PR (lint,db:generate, build)🤖 Generated with Claude Code
https://claude.ai/code/session_01CPViW4Kzn5aFydKQgfV3yq
Summary by Sourcery
Align code quality checks with the Node.js version used in production.
Enhancements:
CI: