Repository navigation
馃悰 Preserve inline child edits when converting syntax trees to tokens - #453
Open
KennyMcSimpson wants to merge 1 commit into
Open
KennyMcSimpson wants to merge 1 commit into
KennyMcSimpson wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SyntaxTreeNode.to_tokens()includes changes to block children but silently drops changes below inline and image nodes. For example, clearing an inline node's children still renders the original paragraph, and clearing image children retains the original alternative text.Rebuild token child lists from the current tree while keeping the original token objects. Add regression coverage for removal, reordering, nested edits and empty inline replacement, document the synchronization, and add a changelog entry.
Validation: the final regression tests produce 3 failures and 1 passing round-trip control on the original implementation. With this change, the complete Python 3.12 suite passes (1,035 tests), and all pre-commit hooks pass, including Ruff and strict mypy. Tests ran in UTF-8 mode on Windows.
Prepared with OpenAI Codex assistance; no independent human review is claimed.