Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request normalizes the error code returned on Android for blocking function errors to match the Apple platform error code ('blocking-cloud-function-returned-error'), updating the documentation, exception handling logic, and tests. The review feedback suggests declaring the 'recognizedCodes' map as 'const' instead of 'final' to avoid allocating a new map on every invocation of '_getCustomCode'.
|
@SelaseKay |
Description
When an authentication blocking function rejects an operation,
FirebaseAuthException.codediffers between Android and Apple platforms:blocking-function-error-responseblocking-cloud-function-returned-errorThis change maps Android's
BLOCKING_FUNCTION_ERROR_RESPONSEmarker toblocking-cloud-function-returned-error, allowing apps to handle thiserror with the same code on Android and Apple platforms.
The existing
invalid-login-credentialsmapping is preserved. The errorcode reference and platform differences table are updated accordingly.
Validation
while preserving the JSON error message.
invalid-login-credentials.firebase_auth_platform_interfacepass.dart run melos run analyze-ci) passes for 59 of61 packages.
firebase_aiandfirebase_ai_examplefail because thelocal
firebase_options.dartconfiguration file is missing. Thesefailures are unrelated to this change.
Related Issues
code names on Android and Apple platforms.
Checklist
///).melos run analyze) does not report any problems on my PR.Breaking Change
On Android, apps that check for
blocking-function-error-responsemustupdate that check to
blocking-cloud-function-returned-error.