Repository navigation
fix: Handle a PostProcessComponent without positional children - #4183
Open
ufrshubham wants to merge 2 commits into
Open
ufrshubham wants to merge 2 commits into
ufrshubham wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PostProcessComponentthrewBad state: No elementfromonChildrenChangedwhenever it had noPositionComponentchildren. That happened when its last child was removed, or when it was added with only non-positional children, such as a plainComponent.When there were no positional children,
_recalculateBoundingSizeset the size to zero but then kept going and calledreduceon the empty list of child rects. It now returns after setting the size to zero.Added tests for both cases.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #4182