Repository navigation
fix(oauth-server): /oauth/authorize fatal error - #326
Merged
Merged
Conversation
The method clashed with AuthorizesRequests::authorize on the base controller, so loading the class was a fatal error and GET /oauth/authorize never worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AuthorizationController::authorize()clashed withAuthorizesRequests::authorize()on the base controller. PHP refused to load the class, soGET /oauth/authorizereturned a fatal error, and with Octane's cached routes a 403. The method is nowstart(); the route and the unit test follow.Found while testing AppHelm's "Continue with Fleetbase Cloud" against a local instance. With this fix,
/oauth/authorizeredirects to the console consent screen.The OAuth server unit tests pass (37).