Repository navigation
feat(flow-php/parquet): DELTA_LENGTH_BYTE_ARRAY / DELTA_BYTE_ARRAY and arrow-rs default encodings - #2702
Merged
Conversation
…d arrow-rs default encodings - read and write DELTA_LENGTH_BYTE_ARRAY and DELTA_BYTE_ARRAY, read uncompressed v2 pages - dictionary on by default (Option::DICTIONARY_ENABLED), arrow-rs fallback encodings under WRITER_VERSION 2 - both engines write and refuse the same COLUMNS_ENCODINGS - fix DELTA_BINARY_PACKED corruption for INT32 and wide bit widths - failed writes leave no file
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2702 +/- ##
============================================
+ Coverage 90.03% 90.10% +0.06%
- Complexity 0 29569 +29569
============================================
Files 2212 2220 +8
Lines 85809 85858 +49
============================================
+ Hits 77260 77363 +103
+ Misses 8549 8495 -54 🚀 New features to boost your workflow:
|
…e parquet read parity test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #737, #696
Change Log
Added
flow-php/parquet- read and write DELTA_LENGTH_BYTE_ARRAY and DELTA_BYTE_ARRAYflow-php/parquet-Option::DICTIONARY_ENABLEDFixed
flow-php/parquet- reading v2 pages flagged as uncompressedflow-php/parquet- DELTA_BINARY_PACKED corruption for INT32 and wide bit widthsflow-php/parquet- all-null pages readable by arrow-rs and DuckDBflow-php/parquet- failed writes leave no file behindflow-php/arrow-ext- invalid COLUMNS_ENCODINGS entries throw instead of panickingChanged
flow-php/parquet- dictionary encoding on by default, arrow-rs fallback encodings under WRITER_VERSION 2flow-php/parquet- RLE_DICTIONARY on BOOLEAN columns is refusedflow-php/arrow-ext- COLUMNS_ENCODINGS writes exactly the given encodingRemoved
flow-php/parquet-PlainFlatColumnChunkBuilderandDeltaBinaryPackedColumnChunkBuilder, replaced byFlatColumnChunkBuilderDeprecated
Security