Repository navigation
Conversation
Exceptions raised by Spring MVC itself (e.g. no handler found for a URL, HTTP method not supported) were handled by the fallback exception handler and returned as 500 Internal server error. They now use the status and headers defined by Spring (e.g. 404, 405 with the Allow header), while the body keeps the Flowable ErrorInfo format.
The management/tables REST resources expose the raw content of the database tables. They are now only registered when the flowable.rest.table-management.enabled property is set to true, which is disabled by default.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
management/tablesREST resources expose raw database table content and are the entry point for the order column SQL injection reported in #4260 (also finding 3 in #4272). This PR makes them opt-in.Changes
Flag for the table resources
flowable.rest.table-management.enabled(defaultfalse).TableCollectionResource,TableResource,TableColumnsResourceandTableDataResourceare not registered, so requests tomanagement/tables/**return 404.Environment, so it works with Spring Boot (including relaxed binding /FLOWABLE_REST_TABLE_MANAGEMENT_ENABLED) as well as plain Spring (@PropertySource, system properties).flowable-default.propertiesof the REST app, and the REST docs.Spring MVC exceptions in the REST error handling
BaseExceptionHandlerAdvicenow uses the status and headers of Spring'sErrorResponse:messageis the problem title andexceptionis the problem detail (the detail is client facing, the exception message can contain internals such as controller method signatures).sendFullErrorExceptionisfalse), but with Spring's status.Upgrade notes
management/tablesREST resources need to setflowable.rest.table-management.enabled=true.Related to #4260 and #4272. Enabling the flag still exposes the unvalidated order column, so validating it remains a follow-up.