Repository navigation
Conversation
The DefaultVariableValueConversionHandler used the system clock when converting ISO 8601 periods and durations (e.g. P10D) to a date or local date. It now uses the clock of the engine configuration, in the same way as the business calendars, so the conversions respect a configured clock. The type conversion tests now use a fixed clock and assert the exact values, which also makes CallActivityTypeConversionTest stable around DST changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DefaultVariableValueConversionHandlerused the system clock when converting ISO 8601 periods and durations (e.g.P10D) to a date or local date. It now uses the clock of the engine configuration, in the same way as the business calendars, so the conversions respect a configured clock.The type conversion tests now use a fixed clock and assert the exact values. This also makes
CallActivityTypeConversionTeststable around DST changes: a period is added in calendar days, so it is not always a multiple of 24 hours when the next days cross a DST change.Check List: