Repository navigation
Conversation
tremblap
marked this pull request as draft
October 27, 2026 13:41
Member
Author
|
example code in SC to see it work and test the dims are right (3x2 is perfect for debugging :) ) |
Member
|
My first thought for the arg name was "by column" (or byCol or whatever is appropriate), which was also one of your suggestions, so there's some resonance there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly for 2D drawing, we need matrix-wide, not column-wise, data processing to preserve the original shape and the relevance of diagonal distances. This is done for the 3 transformers.
At the moment, there are 3 questions for @weefuzzy @jamesb93 and @tedmoore :
Thanks!