Repository navigation
ci(sqflite_tvos): pin sqflite_example_common to a Dart 3.12 commit - #29
Open
TheNoumanDev wants to merge 1 commit into
Open
TheNoumanDev wants to merge 1 commit into
TheNoumanDev wants to merge 1 commit into
Conversation
The example pulls sqflite_example_common from git without a ref. Since tekartik/sqflite@86864c2 it requires Dart ^3.13, so the example no longer resolves on CI's Flutter 3.44 (Dart 3.12) and every PR fails. Pin it to the commit just before that change; the example code is the same as on the last green run.
Contributor
Author
|
@DenisovAV Can you please take a look at this PR and also #28, Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
sqflite_tvosexample pullssqflite_example_commonfrom git without a ref. Since tekartik/sqflite@86864c2 (5 Oct) it requires Dart ^3.13, so the example no longer resolves on CI's Flutter 3.44 (Dart 3.12), and thesqflite_tvosandcichecks fail on every PR (for example #28).This pins it to
aaabf90, the commit just before that change. The example code there is the same as on the last green run.Package(s) touched: sqflite_tvos (example only)
How was it tested?
Versioning & changelog
Checklist
sqflite_tvos/exampleis touched