Repository navigation
path_provider_watchos 0.1.1: upstream's example and test, and iOS's behaviour - #26
Merged
Merged
Conversation
…ehaviour The example was a hand-written demo, and its integration test a copy of upstream's "trimmed to the directories that exist on watchOS". AUTHORING.md §3 asks for upstream's own example and official test, unchanged, so both are now path_provider's, ported with `flutter-watchos plugin port --include-example` (#24). Upstream's test then showed two gaps, fixed in the implementation as §3 asks: - getDownloadsPath threw UnimplementedError. It now returns the user-domain NSDownloadsDirectory path, the lookup path_provider_foundation makes on iOS, through a new FFI export, path_provider_watchos_downloads_path. - The external storage getters threw UnimplementedError. They now throw UnsupportedError, as on iOS. On the watchOS 27.0 Simulator all 16 of upstream's tests pass, and the example starts with no exception in its first 15 seconds and no overflow.
Member
Author
|
Re-checked the example's start the way spec 0006 criterion 8a asks: built with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #24.
Example. Our example was a hand-written demo, and its integration test a copy of upstream's "trimmed to the directories that exist on watchOS". AUTHORING.md §3 asks for upstream's own example and official test, unchanged. Both are now
path_provider's, ported withflutter-watchos plugin port --include-example. The only change is the formatting our CI checks, and there are no watchOS deviations.Implementation. Upstream's test found two gaps, fixed in the implementation as §3 asks:
getDownloadsPaththrewUnimplementedError. It now returns the user-domainNSDownloadsDirectorypath, the same lookuppath_provider_foundationmakes on iOS, through a new FFI export,path_provider_watchos_downloads_path.UnimplementedError. They now throwUnsupportedError, as on iOS.Verified
UnsupportedErrorcases. The new.mcode compiles in that build.UnsupportedErrorcases (for everyStorageDirectory).flutter analyze lib testis clean.pub publish --dry-runraises no other warning.Version 0.1.1 with a CHANGELOG entry. The README and PORTING_REPORT (verification status, Example section, interface coverage) are updated.