Repository navigation
url_launcher_watchos 0.1.2: upstream's example and official test - #27
Merged
Merged
Conversation
The example was a hand-written demo. AUTHORING.md §3 asks for upstream's own example and official test, unchanged, so both are now url_launcher's, ported with `flutter-watchos plugin port --include-example` (#24). The example's pubspec adds `path`, which upstream's lib/files.dart imports. The report said upstream's test was not reused because it asserts an in-app SFSafariViewController. That is url_launcher_ios's test; the app-facing url_launcher's test, which the porter takes, checks canLaunchUrl and the legacy canLaunch, and passes verbatim. Our former test stays beside it as watchos_url_launcher_test.dart: the on-watch browser, Handoff and the refused schemes. On the watchOS 27.0 Simulator both tests pass (1 and 6), and the example starts with no exception in its first 15 seconds and no overflow.
Member
Author
|
Re-checked the example's start the way spec 0006 criterion 8a asks: built with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #24.
Example. Our example was a hand-written demo. It is now
url_launcher's own example app with its official integration test, both unchanged apart from the formatting our CI checks, ported withflutter-watchos plugin port --include-example. There are no watchOS deviations. The example's pubspec addspath, which upstream'slib/files.dartimports.Tests. The report said upstream's test was not reused because it asserts an in-app
SFSafariViewController. That is url_launcher_ios's own test. The test the porter takes is the app-facing url_launcher's, which checkscanLaunchUrland the legacycanLaunch, and it passes as is. Our former test stays beside it aswatchos_url_launcher_test.dart, covering the on-watch browser, Handoff and the refused schemes.Verified on the watchOS 27.0 Simulator
url_launcher_test.dart(upstream): passes.watchos_url_launcher_test.dart: 6 pass.canLaunchUrl(tel:)answers at start, so the "Make phone call" button shows.Unit tests (16) and
flutter analyze lib testare clean. The repo's version, example-constraint, README-snippet, test-name, word and format checks pass.Version 0.1.2 with a CHANGELOG entry. The README gains an Example section, and the PORTING_REPORT gets its verification rows and an Example section.