Repository navigation
geolocator_watchos 0.2.1: pending requests share the most accurate accuracy - #32
Merged
Merged
Conversation
…curacy With several getCurrentPosition calls pending, each call passed its own accuracy to the shared single-request manager, so the last call's won. geolocator_apple 2.4.3 runs the shared request at the most accurate of the pending ones (MIN of CLLocationAccuracy) until the last one ends, and so does this package now (#18). The rule lives in Dart, ranked by the desiredAccuracy native sets for each LocationAccuracy: bestForNavigation -2 m, best -1, high 10, medium 100, low 1000, lowest 3000, reduced 6380 km (kCLLocationAccuracyReduced, read on macOS). Native is unchanged; its header says what Dart passes. Three tests: the ranking across pending calls and the reset after the last one, reduced against lowest and bestForNavigation against best, and a call that times out leaving the others at the accuracy they share. All three fail with the old rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18.
Bug. With several
getCurrentPositioncalls pending, each call passed its own accuracy to the shared single-request manager, so the last call's won. geolocator_apple 2.4.3 runs the shared request at the most accurate of the pending ones (MINofCLLocationAccuracy) until the last one ends.Fix. This package now does the same. The rule lives in Dart, where host tests reach it, ranked by the
desiredAccuracynative sets for eachLocationAccuracy:desiredAccuracykCLLocationAccuracyReduced, read on macOS)Native is unchanged; its header comment now says what Dart passes.
Tests. Three new ones, all failing with the old rule:
reducedagainstlowest, andbestForNavigationagainstbest;flutter analyze lib testis clean, and 29 tests pass. Version 0.2.1 with a CHANGELOG entry; the README and PORTING_REPORT describe the rule.