Repository navigation
fix(core): allow project arrays in framework build options - #25534
Draft
nicohrubec wants to merge 1 commit into
Draft
nicohrubec wants to merge 1 commit into
nicohrubec wants to merge 1 commit into
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Framework build options reject project arrays that the bundler plugins already support. Widen the shared option and handle React Router's single-project CLI clients by associating releases with all configured projects and uploading through one client per project. Debug IDs are injected once, and source maps are preserved if an upload fails.
Adds focused coverage for multi-project uploads, cleanup ordering/failures, empty arrays, omitted projects, and array-valued framework configurations.
Fixes #21069
React Router's build, lint, and all 268 tests pass; the focused type fixtures and the Nuxt, SvelteKit, SolidStart, Remix, Nitro, and TanStack Start suites also pass. Broader local checks encounter existing install/build issues: missing pnpm metadata, outdated conventions exports and Node declarations, and no current SDK tarballs for E2E tests.