Repository navigation
feat(tracing): Add span links - #8068
Merged
Merged
Conversation
Contributor
Coverage Results 📊✅ 56441 passed | ⏭️ 2890 skipped | Total: 59331 | Pass Rate: 95.13% | Execution Time: 150m 54s 📊 Comparison with Base Branch
➖ Removed Tests (58)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00% (31 of 31 changed executable lines covered; target 80%). Changed files with executable lines (2)
Coverage diff@@ Coverage Diff @@
## master #8068 +/-##
==========================================
- Coverage 90.31% 90.05% -0.26%
==========================================
Files 203 197 -6
Tracked lines 26866 21086 -5780
Branches 10030 7260 -2770
==========================================
- Hits 24262 18988 -5274
+ Misses 2604 2098 -506
+ Partials 1517 1236 -281Generated by Coverage Action |
pabloDeputter
marked this pull request as ready for review
October 20, 2026 11:27
sentrivana
approved these changes
Oct 23, 2026
sentrivana
left a comment
sentrivana
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but please address comments before merging
| if "attributes" in link | ||
| else link | ||
| for link in item["links"] | ||
| ] |
Collaborator
There was a problem hiding this comment.
If there are no links, would we still send an empty links key? If so, we should delete it like we do for attributes on L186, to keep the payload as small as possible.
Member
Author
There was a problem hiding this comment.
No links isn't set when there aren't any; they are only set in Span._to_json() @ traces.py:577 when there's > 1 link to be sent.
Comment on lines
+189
to
+200
| res["links"] = [ | ||
| { | ||
| **link, | ||
| "attributes": { | ||
| k: serialize_attribute(v) | ||
| for (k, v) in link["attributes"].items() | ||
| }, | ||
| } | ||
| if "attributes" in link | ||
| else link | ||
| for link in item["links"] | ||
| ] |
Collaborator
There was a problem hiding this comment.
Can we maybe unfurl this into statements instead of the one big list comprehension? Easier to parse that way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds span links as is specified in the specs: a span can reference other spans, e.g. in other traces, without making them its parent.
sentry_sdk.start_span(..., links=[...]),span.add_link(link)andspan.add_links(links); with links being of the following format:{"trace_id", "span_id", "sampled"?, "attributes"?}linksNoOpSpanignores linksRelated docs update can be found here.
Why
An SQS/SNS consumer can receive a batch of records sent by several producers, each in its own trace. A span can only have one parent, so without links there's no way to connect the consumer each producer. With links the consumer span can point to each producer's trace.