Skip to content

fix(wsgi): Redact CF-Connecting-IP, True-Client-IP, Forwarded, and X-Client-IP by default #8108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryder777777 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(wsgi): Redact CF-Connecting-IP, True-Client-IP, Forwarded, and X-Client-IP by default #8108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f10a747
fix(wsgi): Redact CF-Connecting-IP, True-Client-IP, Forwarded, and X-…
ryder777777 Oct 22, 2026
91a837e
test(wsgi): Match title-cased WSGI header names in test_wsgi
ryder777777 Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sentry_sdk/integrations/_wsgi_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,11 @@
"HTTP_AUTHORIZATION",
"HTTP_PROXY_AUTHORIZATION",
"HTTP_X_API_KEY",
"HTTP_X_FORWARDED_FOR",
"HTTP_X_REAL_IP",
"HTTP_CF_CONNECTING_IP",
"HTTP_TRUE_CLIENT_IP",
"HTTP_FORWARDED",
"HTTP_X_CLIENT_IP",
)

SENSITIVE_HEADERS = tuple(
Expand Down
25 changes: 18 additions & 7 deletions tests/integrations/wsgi/test_wsgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,20 +890,31 @@ def test_request_headers_legacy_no_pii_redacts_sensitive(
"/",
headers={
"X-Forwarded-For": "1.2.3.4",
"X-Real-IP": "1.2.3.5",
"CF-Connecting-IP": "1.2.3.6",
"True-Client-IP": "1.2.3.7",
"Forwarded": "for=1.2.3.8",
"X-Client-IP": "1.2.3.9",
"X-Custom-Header": "passthrough",
},
)

(event,) = events

assert event["request"]["headers"]["X-Forwarded-For"] == ""
assert event["request"]["headers"]["X-Custom-Header"] == "passthrough"
for header in (
"X-Forwarded-For",
"X-Real-Ip",
"Cf-Connecting-Ip",
"True-Client-Ip",
"Forwarded",
"X-Client-Ip",
):
assert event["request"]["headers"][header] == ""
assert event["_meta"]["request"]["headers"][header] == {
"": {"rem": [["!config", "x"]]}
}

# The emptied value is accompanied by a `_meta` annotation marking it as
# removed, confirming the substitution came from the AnnotatedValue path.
assert event["_meta"]["request"]["headers"]["X-Forwarded-For"] == {
"": {"rem": [["!config", "x"]]}
}
assert event["request"]["headers"]["X-Custom-Header"] == "passthrough"


def test_request_headers_data_collection_off_collects_no_headers(
Expand Down