Repository navigation
fix(core): Match Sentry package paths with Windows separators in Metro resolvers - #6915
Merged
Merged
Conversation
…o resolvers On Windows, Metro gives `originModulePath` with backslashes. The `@sentry/browser` and `@sentry/core` origin checks searched for a forward slash, so they never matched. With `includeWebFeedback: false`, the bundle then kept `feedbackSync.js`, which calls the stubbed `buildFeedbackIntegration()` at load time and crashes the app at launch. Server-only `@sentry/core` modules also stayed in native bundles. Match both separators in the two origin checks. Fixes #6913
…lver fix Replace the placeholder with the number of the opened PR.
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
📲 Install BuildsAndroid
|
antonis
approved these changes
Oct 20, 2026
antonis
left a comment
antonis
left a comment
Contributor
There was a problem hiding this comment.
The changes and the tests LGTM. Note that I didn't actually test on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The Metro resolvers now match the
@sentry/browserand@sentry/coreorigin paths with forward slashes and with backslashes. Before, they matched only forward slashes, so on Windows the@sentry/browserfeedback wrappers and the server-only@sentry/coremodules stayed in native bundles.💡 Motivation and Context
With
includeWebFeedback: false, bundles made on Windows keptfeedbackSync.js. This file calls the stubbedbuildFeedbackIntegration()at load time, so the app crashed at launch. Fixes #6913.💚 How did you test it?
I added resolver tests that use Windows paths. They failed before the fix and pass after it. All tool tests, oxlint, oxfmt, and madge pass.
📝 Checklist
sendDefaultPIIis enabled.