Repository navigation
Only cache real pub archives on download - #520
Merged
Merged
Conversation
…dev and cached it as the archive, so one request broke that version for everyone after; they now get a 404, and the upstream URL is built from the escaped name and version so an encoded ? or # can't become a query or fragment.
…re now discarded and fetched again, so versions that were already broken heal on the next download.
simonchrz
approved these changes
Oct 19, 2026
simonchrz
left a comment
simonchrz
left a comment
Contributor
There was a problem hiding this comment.
Approving. Verified that mirrored pub artifacts aren't caught by the cleanup: registries builds pub download URLs with the .tar.gz suffix, so their UpstreamURL passes the check. Tests pass locally.
Non-blocking: discardVersionPage adds a GetArtifact lookup to every pub download, cache hits included, only to repair entries from older versions. That's cheap, but it could be dropped again after a release or two. Worth a comment saying so.
andrew
approved these changes
Oct 19, 2026
andrew
left a comment
andrew
left a comment
Contributor
There was a problem hiding this comment.
The archive suffix check prevents version pages from entering the archive cache, and the repair path preserves valid cached archives. No actionable findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pub downloads without
.tar.gzfetched the HTML version page from pub.dev and cached it as the archive. One request to/pub/packages/http/versions/1.2.0was enough to breakhttp-1.2.0.tar.gzfor everyone after.Such requests now get a 404. Invalid package names are rejected, and the upstream URL is built from the escaped name and version, so an encoded
?or#can't turn into a query or fragment.Archives that were already cached this way are discarded and fetched again on the next download.