Repository navigation
Remove github/copilot-plugins entries from catalog - #85
Open
dhruvchand wants to merge 2 commits into
Open
dhruvchand wants to merge 2 commits into
dhruvchand wants to merge 2 commits into
Conversation
Content from github/copilot-plugins should not be discoverable through Agent Finder. Remove the two contributor-managed entries sourced from that repository (Spark and Spark App Template) and drop the matching generated entries from ai-catalog.json. The ai-catalog.json change is limited to these removals; MCP Registry refresh drift is left to the automated refresh pull request. Companion change: github/agentfinder#581 adds github/copilot-plugins to Agent Finder's manual T2 trust overrides. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 963f4f04-fc78-4352-83e3-e47ebe9fc894
There was a problem hiding this comment.
🔵 Needs a closer look
The companion service change could not be verified, and the broader live-registry refresh warrants human review.
0 open findings
What changed in this PR
Removes github/copilot-plugins resources from Agent Finder’s curated catalog, complementing the companion service-side trust override.
Changes:
- Deletes the Spark plugin and Spark App Template source entries.
- Removes their generated counterparts and refreshes unrelated live MCP Registry data.
| File | Description |
|---|---|
catalog/github/spark.json |
Deletes the Spark plugin entry. |
catalog/github/spark-app-template.json |
Deletes the Spark App Template skill entry. |
ai-catalog.json |
Removes both entries and refreshes registry metadata and versions. |
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes every catalog entry whose content comes from
github/copilot-plugins, so that repository's contents no longer appear in Agent Finder.catalog/github/spark.json(the Spark plugin).catalog/github/spark-app-template.json(the Spark App Template skill).ai-catalog.json.A repository-wide search finds no other
copilot-pluginsreferences. Neither entry has an icon declaration incatalog-icons.json.Companion change
github/agentfinder#581 adds
github/copilot-pluginsto Agent Finder's manual T2 trust overrides. After this PR merges, github/agentfinder's dailysync-catalogworkflow drops these entries from the embeddedlaunch_augment_set.json.Notes
ai-catalog.jsondiff only removes these two entries. Against a frozen GitHub MCP Registry snapshot, it is byte-identical to the generator's output for these deletions. The live registry has drifted since the last refresh, so the Catalog workflow may push an "Update generated ARD catalog" commit with unrelated registry changes. That is the same drift Update generated ARD catalog #78 tracks.kusto_name_mapping.kqlkeeps its "Spark App Template" row. It is a telemetry name/hash lookup that Agent Finder doesn't use for discovery, and earlier catalog removals haven't edited it.Validation
ai-catalog.json. The local harness skipped Pillow's PNG decoding of icon assets; icon URL, provenance, and SHA-256 checks still ran.python -m unittest tests.test_awesome_copilot_plugin_refs tests.test_fix_plugin_media_types tests.test_catalog_workflowpasses.tests/test_generate_ai_catalog.pywas not run locally because it needs Pillow, which couldn't be downloaded on this network. CI runs the full suite.