Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized arithmetic fix prevents intermediate integer overflow while preserving the metric’s intended behavior.
0 open findings
What changed in this PR
Fixes integer overflow in the unified analysis-quality metric for taint reach per million nodes.
Changes:
- Uses floating-point arithmetic before flooring the result, preserving integer output and zero-candidate handling.
| File | Description |
|---|---|
| unified/ql/lib/codeql/unified/internal/AnalysisQuality.qll | Avoids overflow in the per-million calculation. |
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes integer overflow on some projects. Do the division as floating point and truncate afterwards.