fix(extensions): skip catalog entries without a version on update by MannXo · Pull Request #5108 · github/spec-kit

MannXo · 2026-10-24T17:35:14Z

Description

discover_updates read the catalog version with ext_info["version"], so a catalog entry without version made specify extension update exit 1 with KeyError: 'version', and the installed extensions after it were never checked. A null or list value crashed the same way, with TypeError and AttributeError.

This PR accepts the catalog version only when it is a string. Anything else is skipped with a warning and the loop carries on. A missing version is reported as Missing catalog version, and any other type (null, a list, or a number such as 2) as Invalid catalog version: expected a string, got <type>, in the style of ExtensionManifest validation. An unparseable string keeps the existing Invalid catalog version '<value>' warning. Entries with a valid version behave as before. A number is rejected rather than converted: the download step passes the catalog's raw value to build_safe_download_path, which accepts only a string (_download_security.py:442), so a numeric version would be offered as an update that then fails to download.

The issue's repro script, on main (67e0f72), last traceback line only:

exit code: 1
🔄 Checking for updates...

Warning: Using non-default extension catalog. Only use catalogs from sources you trust.

KeyError: 'version'

With this PR:

exit code: 0
🔄 Checking for updates...

⚠  aaa: Missing catalog version (skipping)
✓ bbb: Up to date (v1.0.0)

All extensions are up to date!
Warning: Using non-default extension catalog. Only use catalogs from sources you trust.

The same script with "version": 2 on aaa:

⚠  aaa: Invalid catalog version: expected a string, got int (skipping)
✓ bbb: Up to date (v1.0.0)

Fixes #5082

Testing

Tested locally with uv run specify --help
Ran existing tests with uv sync && uv run pytest
Tested with a sample project (if applicable)

New tests:

test_discovery_skips_catalog_entry_without_valid_version in tests/specify_cli/extensions/test_command_update_discovery.py, for a missing, null, list, numeric and unparseable version. The broken entry comes first, and the test checks the exact skip warning for each case and that the second extension's update is still found.
test_update_skips_catalog_entry_without_version in tests/specify_cli/extensions/test_command_update.py runs specify extension update through the CLI and checks exit code 0, the Missing catalog version warning, and an unchanged registry.

With only src/ reverted to main, the 5 missing and wrong-type cases fail (KeyError, TypeError, AttributeError, exit code 1). With the fix, the 32 tests in those two files pass.

Full suite on macOS, Python 3.14.6, pytest -n 2 as in CI: 12808 passed, 434 skipped, none failed.

uvx ruff@0.15.0 check src tests passes, and so does git diff --check.

AI Disclosure

I did not use AI assistance for this contribution
I did use AI assistance (fill in the disclosure below)

AI disclosure: Claude Code (model: claude-opus-5-5, autonomous) reproduced the bug, wrote the fix and tests, ran the suite and lint, and drafted this description.

`specify extension update` read the catalog version with `ext_info["version"]`, so an entry with no `version` raised KeyError, and a null or list value raised TypeError or AttributeError. Any of these aborted the command before the remaining installed extensions were checked. Read the value the way `specify workflow update` does, so these entries take the existing "Invalid catalog version ... (skipping)" path. Fixes github#5082

Copilot

🟡 Changes recommended

Numeric catalog versions now pass discovery but are rejected during download, offering updates that cannot complete.

1 open issue

Reject non-string catalog versions before offering updates · New

What changed in this PR

Addresses #5082 by preventing missing or malformed catalog version fields from aborting Specify CLI extension update checks.

Changes:

Reads catalog versions defensively and reuses the existing skip warning.
Adds discovery and CLI regression coverage for malformed entries, continued checking, and unchanged installed state.

The PR’s reported before-and-after results were reviewed; project tests were not rerun here.

File	Description
`tests/specify_cli/extensions/test_command_update.py`	Checks successful CLI completion, the skip warning, and unchanged registry state.
`tests/specify_cli/extensions/test_command_update_discovery.py`	Covers missing, null, and list versions while verifying discovery continues.
`src/specify_cli/extensions/_command_update_discovery.py`	Converts optional catalog version values to strings before parsing.

_{Review effort: Max}

mnriem · 2026-10-26T14:24:59Z

Please address Copilot feedback

…date A numeric catalog version such as `"version": 2` passed discovery once coerced with str(), but the download rejects non-string versions, so the update was offered and then always failed. Require a string and take the existing "Invalid catalog version ... (skipping)" path otherwise.

Copilot

🟢 Approval recommended

The narrowly scoped fix has targeted regression coverage and no unresolved blocking issues.

1 open issue

Update version handling documentation and test summary · New

1 resolved since last review

Reject non-string catalog versions before offering updates

_{Review effort: Max}

+            if not isinstance(raw_catalog_version, str):
+                raise pkg_version.InvalidVersion(raw_catalog_version)


mnriem · 2026-10-26T20:14:04Z

Please address Copilot feedback

MannXo · 2026-10-29T08:45:32Z

Addressed in 7cef29a. Discovery now accepts a catalog version only when it is a string, so a number such as 2 takes the existing skip path instead of being offered as an update that the download then rejects. {"version": 2} is added to the parametrized discovery test, and the description is updated to say versions are string-only.

Copilot

🟢 Approval recommended

No active review issues are identified for the change to skip malformed catalog versions during extension update checks.

1 open issue

Update version handling documentation and test summary

_{Review effort: Max}

mnriem · 2026-10-29T11:38:47Z

Please address Copilot feedback

MannXo · 2026-10-29T14:59:52Z

The open Copilot thread at _command_update_discovery.py:103 is about the PR description, not the code, and the description already says versions are string-only (second paragraph) and lists the numeric case under Testing. Copilot's latest review on 7cef29a raised nothing new, so that thread only needs resolving, which I've left to you.

Copilot

🟡 Changes recommended

An active finding notes that non-string catalog versions produce a misleading warning rather than explicitly identifying the expected and received types.

2 open issues

_{Review effort: Max}

+            if not isinstance(raw_catalog_version, str):
+                raise pkg_version.InvalidVersion(raw_catalog_version)


mnriem · 2026-10-29T16:13:18Z

Please address Copilot feedback. If not applicable, please explain why

A catalog entry with "version": 2 was reported as "Invalid catalog version '2'", which reads as a rejected version string. Report a missing version and a non-string one separately, naming the received type as ExtensionManifest validation does.

MannXo · 2026-10-29T19:10:53Z

Addressed in bfb786b. A missing catalog version now warns Missing catalog version, and a non-string one says expected a string, got int (or whichever type it received), with the exact warnings asserted in both test files. The description is updated to match, and it also covers the older :103 thread about the description.

MannXo requested a review from mnriem as a code owner October 24, 2026 17:35

mnriem added the triage-must-have Verdict: high-value, important work for Spec Kit — do first label Oct 25, 2026

mnriem requested a max review from Copilot October 26, 2026 13:23

Copilot started reviewing on behalf of mnriem October 26, 2026 13:24

View session

Copilot AI reviewed Oct 26, 2026

View reviewed changes

Comment thread src/specify_cli/extensions/_command_update_discovery.py Outdated

mnriem added the author-awaiting Waiting on author response label Oct 26, 2026

mnriem requested a max review from Copilot October 26, 2026 16:34

Copilot started reviewing on behalf of mnriem October 26, 2026 16:35

View session

Copilot AI reviewed Oct 26, 2026

View reviewed changes

Comment thread src/specify_cli/extensions/_command_update_discovery.py Outdated

Comment on lines +102 to +103

if not isinstance(raw_catalog_version, str):

raise pkg_version.InvalidVersion(raw_catalog_version)

mnriem requested a max review from Copilot October 29, 2026 11:19

Copilot started reviewing on behalf of mnriem October 29, 2026 11:20

View session

Copilot AI reviewed Oct 29, 2026

View reviewed changes

mnriem requested a max review from Copilot October 29, 2026 15:39

Copilot started reviewing on behalf of mnriem October 29, 2026 15:40

View session

Copilot AI reviewed Oct 29, 2026

View reviewed changes

Comment thread src/specify_cli/extensions/_command_update_discovery.py Outdated

Comment on lines +102 to +103

if not isinstance(raw_catalog_version, str):

raise pkg_version.InvalidVersion(raw_catalog_version)

Navigation Menu

Repository navigation

fix(extensions): skip catalog entries without a version on update - #5108

fix(extensions): skip catalog entries without a version on update#5108
MannXo wants to merge 3 commits into
github:mainfrom
MannXo:fix/5082-update-missing-version

MannXo commented Oct 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

mnriem commented Oct 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

mnriem commented Oct 26, 2026

Uh oh!

MannXo commented Oct 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

mnriem commented Oct 29, 2026

Uh oh!

MannXo commented Oct 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

mnriem commented Oct 29, 2026

Uh oh!

MannXo commented Oct 29, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		if not isinstance(raw_catalog_version, str):
		raise pkg_version.InvalidVersion(raw_catalog_version)

Conversation

MannXo commented Oct 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

AI Disclosure

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

mnriem commented Oct 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

mnriem commented Oct 26, 2026

Uh oh!

MannXo commented Oct 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

mnriem commented Oct 29, 2026

Uh oh!

MannXo commented Oct 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

mnriem commented Oct 29, 2026

Uh oh!

MannXo commented Oct 29, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MannXo commented Oct 24, 2026 •

edited

Loading