Repository navigation
Try generic Repo Assist tasks before concluding there is no work - #409
Merged
Merged
Conversation
Generate an ordered testing, performance and forward-progress fallback plan beyond the initial random selection, bound repeated assessments, and preserve command-mode and safety restrictions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep generic fallback disabled for scheduled maintenance-only runs and cover cap/manual interactions alongside all initial task selections. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Hosted validation after integrating current main: all 23 tests passed (11 fallback tests and 12 maintenance/capacity tests), including all 120 initial selections and the new scheduled-cap/manual-exemption cases. Run: https://github.com/githubnext/agentics/actions/runs/40116214786. CI then fails only at the two inherited hosted-workflow native fetch declarations fixed independently in #408. The merge conflict with the now-merged maintenance-only change is resolved; this PR remains a three-file fallback-only diff against main. Local focused compilation/freshness also passed. No workflow was manually dispatched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the initially selected tasks and their local fallbacks find no actionable work, Repo Assist should try useful generic repository work even if those tasks were not randomly selected.
generic_fallback_tasksin the real task-selection JSON: testing (9), performance (8), take the repository forward (10), then docs/QA (7), engineering (4), and code improvements (5), excluding initially selected tasks.This branch independently targets
main, not the separate fetch-compatibility branch. It incorporates the newly merged #407 to resolve their overlap and explicitly preserves maintenance-only mode; the net PR diff contains only the fallback workflow, documentation and tests.Validation
python3 -m unittest discover -s tests -p 'test_repo_assist_*.py' -v: 23 tests passed (11 generic-fallback tests plus 12 existing maintenance/capacity tests), exercising the actual inline task-selection Python, including all 120 possible initial three-task combinations, empty backlogs, explicit/blank commands, scheduled capacity/manual exemptions and run-seed reproducibility.gh aw compile workflows/repo-assist.md: passed with gh-aw v0.93.3; freshness reports Yes.git diff --check: passed.Sample
workflows/*.lock.ymlfiles are intentionally ignored here, so the regenerated sample lock is validated locally rather than force-added. Current compiler scaffolding warnings remain visible. Until #408 merges, hosted compilation still encounters the two unsupported native fetch declarations onmain. That PR has now confirmed all 5 hosted workflows compile, then exposed 14 additional unchanged reusable samples with unsupported native fetch entries; those are outside this fallback-only change.Compatibility / safety
The current-compiler compatibility changes (removing native Copilot
web-fetchand normalizingrequest_reviewtorequest-review) are already onmainthrough #407. This PR does not broaden network allowlists or write privileges. The existing memory validator is unchanged and no migration is added.A read-only safety review found no confirmed vulnerability in the changed scope. The new command value is passed as data through an environment variable and checked only for nonblank content; it is never evaluated as code. The test harness uses disposable files and mocked inputs, with no API/network calls or credential use. Runtime telemetry values and actual agent adherence remain unverified; no live execution is claimed.