Repository navigation
fix(landing): show the desktop scope instead of the install block on phones - #232
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #224 and #227.
Problem
Below 861 px the install section still showed a
sudo pacman -Ucommand, a copy button and requirement cards about GNOME,nextcloudcmdandcargo build. A phone visitor cannot act on any of it, and the hero stopped offering the install CTA in #227, so the page led them to dead weight.Changes
landing/index.html: the desktop heading and lead get aninstall-deskclass, and a mobile-only block states the real scope: NextSync is a Linux desktop application designed for GNOME, with no Android or iOS version.landing/styles.css: the mobile block is hidden by default, and below 861 px it replaces the install card and the requirement cards.landing/i18n.js:install.mTitleandinstall.mBodyin ES and EN. Cache-bust to?v=7.Desktop content stays in the DOM, only hidden at that width, so SEO and desktop behaviour do not change. No other app is mentioned or recommended.
Verification
Playwright suite at 360, 390, 414, 1280 and 1440 px: 62/62 checks passing locally and 62/62 against production.
Already deployed to https://nextsync.cloudless.club/ and verified there.
Closes #231