Skip to content

refactor(config): drop the unused color_scheme setting - #253

Merged
gnacho merged 1 commit into
mainfrom
fix/246-dead-color-scheme
Oct 29, 2026
Merged

gnacho merged 1 commit into
mainfrom
fix/246-dead-color-scheme

Conversation

@gnacho

@gnacho gnacho commented Oct 29, 2026

Copy link
Copy Markdown
Owner

The theme switch was removed in v0.70.0 (issue #53), so nothing reads
general.color_scheme: it was parsed, validated and written back, with no
effect on the UI.

Change

  • Drop the field, its default and its validation from GeneralConfig.
  • Replace the old fallback test with one that proves the compatibility path:
    a config carrying "color_scheme": "banana" still loads, and the key is
    gone the next time the config is written. No schema_version bump is
    needed, the crate never sets deny_unknown_fields.

Verification

cargo fmt --check, cargo clippy --all-targets -- -D warnings and
cargo test clean, 739 tests passing.

Closes #246

The theme switch was removed in v0.70.0 (issue #53), so nothing reads this
field. Old configs still carry the key: unknown keys are ignored on load and
the key disappears on the next save, so no schema bump is needed.

Closes #246
@gnacho
gnacho merged commit 14b9a5e into main Oct 29, 2026
2 checks passed
@gnacho
gnacho deleted the fix/246-dead-color-scheme branch October 29, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

config: general.color_scheme is stored but never applied

1 participant