Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Customising a shared Taskfile locally today means copying the whole file over a
.distvariant (see #1873). When Task discovers the root Taskfile itself, it now also loads an optionalTaskfile.override.ymlnext to it:varsandenvmerge by key with the override winning,tasksare added or replaced whole, and any other root key is an error. Naming the file with--taskfileskips the override; included, remote and stdin Taskfiles never load one.Reviewer decision: tasks are replaced whole rather than merged field by field, so #1873's own example (overriding only a task's
env) needs the value moved to a variable. The JSON schema is not covered yet: editors won't recogniseTaskfile.override.ymluntil SchemaStore maps it, and the main schema would accept keys the override rejects.Test plan
TestAutomaticOverride(golden,testdata/override): discovery, subdirectory with a stray invalid override,-tfile vs-tdirectory,TASKFILE/ROOT_TASKFILEfor an added task.taskfile/override_test.go: merge semantics and ordering, override name priority, decode/version/forbidden-key errors, unreadable override, override applied before includes and conflict with an included task, remote and stdin roots ignored.TestAutomaticOverrideGlobal:--globalloads the override from the home directory.