Repository navigation
Add utask waiting time metric - #5545
Merged
Merged
Conversation
Define the metric in `monitoring_metrics.py` and instrument the code to emmit it.
Improve unittests that used serialize_and_upload_uworker_input, now they actually test the behaviour and not how the code is written. Add some tests to check for preprocess_end_time being set and for the metric emmission.
decoNR
reviewed
Oct 21, 2026
decoNR
reviewed
Oct 23, 2026
decoNR
approved these changes
Oct 27, 2026
ViniciustCosta
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: b/573118558
Overview
Creates a new metric called
UTASK_SUBTASK_WAIT_DURATION_SECS, which keeps track of time spent between one subtask finishing and the next one starting. This PR only implements it for themainsubtask (so it tracks time betweenpreprocessandmain).Changes
UTASK_SUBTASK_WAIT_DURATION_SECSand instrument the code to emit it in themainsubtask.preprocess_end_timetouworker_msg.Inputprotobuf.serialize_and_upload_uworker_inputin two parts, moving all URLs generation/signing toprepare_uworker_io_urlsin order to precisely track the timepreprocessfinishes.serialize_and_upload_uworker_input: now they actually test the underlying behavior of the function instead of how its code is written.time_nsmethod tohelpers.MockTime.Tests
Add additional checks in
UworkerMainTestandTworkerPreprocessTestto check ifpreprocess_end_timeis set correctly and ifUTASK_SUBTASK_WAIT_DURATION_SECSis emitted.I deployed in the dev environment and it's working as intended. Evidence in the bug comments.