Repository navigation
Conversation
This was referenced Oct 27, 2026
A stage's outcome alone doesn't say where it failed or spent its time. This adds `logs.step(name)` markers to the 8 utasks and includes each step's duration in the stage's `stage_summary`. A step lasts until the next one starts or the stage ends, so a stage that fails or returns early ends in the step responsible, without per-exit bookkeeping in task code. The framework marks its own input and output uploads, so their time isn't charged to the task's last step. Stages with a single step (variant preprocess and the symbolize, variant and corpus pruning postprocess) are left unmarked, since their step would be the stage itself.
smolkaj
force-pushed
the
stage-summary-steps
branch
from
October 27, 2026 22:36
1fa51ac to
3f18765
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #5557; the diff is against that branch.
A stage's outcome alone doesn't say where it failed or spent its time. This adds
logs.step(name)markers to the 8 utasks and includes each step's duration in the stage'sstage_summary. A step lasts until the next one starts or the stage ends, so a stage that fails or returns early ends in the step responsible, and task code needs no per-exit bookkeeping. The framework marks its own input and output uploads, so their time isn't charged to the task's last step.Stages with a single step (variant preprocess and the symbolize, variant and corpus pruning postprocess) are left unmarked, since their step would be the stage itself.
The step names are the part most open to debate, and we'd value your suggestions on what's meaningful to someone who knows these tasks. We'd also like to hear whether you're comfortable with markers in task code at all; if not, stage-level records (#5557) on their own are still useful to us.
cc @IvanBM18 @g-ortuno for visibility