Repository navigation
Fix copy-pasted account wording in property access binding samples - #74
Open
Avicennasis wants to merge 1 commit into
Open
Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
Signed-off-by: Léon Avic Simmons <Avicennasis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The six
google-analytics-admin/properties_access_bindings_*.pysamples were copied from the account access binding samples and still describe the ID as an account access binding ID. Fixed inproperties_access_bindings_{get,update,delete,batch_get,batch_update,batch_delete}.py:property_access_binding_id: "Google Analytics account access binding ID." -> "Google Analytics property access binding ID.""YOUR-ACCOUNT-ACCESS-BINDING-ID"->"YOUR-PROPERTY-ACCESS-BINDING-ID". This is the string users replace before running the sample; the tests read the ID fromGA_TEST_PROPERTY_ACCESS_BINDING_IDand never touch itNo functional changes — comments, docstrings and a placeholder string only.