Repository navigation
test(storage): Parameterized test setup for RCU integration testing - #14530
Open
nidhiii-27 wants to merge 3 commits into
Open
nidhiii-27 wants to merge 3 commits into
nidhiii-27 wants to merge 3 commits into
Conversation
- Add LocationType enum and integrate with CrossRun / SingleBackend annotations and CrossRunIntersection - Update StorageITRunner to support location-based parameterized permutations - Add PREPROD backend resources and dynamic bucket lifecycle management in BackendResources - Add RapidCache lifecycle support and cleanup in BucketInfoShim - Update HttpStorageRpc to properly handle custom subpaths in endpoint URIs - Add unit tests for HttpStorageRpc endpoint URI handling [Generated-by: AI]
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for a new PREPROD backend and adds a LocationType enum to support regional standard, regional rapid, and zonal rapid bucket topologies in integration tests. It also updates HttpStorageRpc to parse custom hosts with subpaths into distinct root URLs and service paths. The review feedback highlights two key improvements: first, using uri.getRawPath() instead of uri.getPath() in HttpStorageRpc to avoid potential StringIndexOutOfBoundsException issues with percent-encoded characters; second, overriding the target region and zone for ZONAL_RAPID buckets (similar to REGIONAL_RAPID) to prevent test failures in zones that do not support the rapid cache storage class.
…cation 1. Use uri.getRawPath() in HttpStorageRpc to handle raw percent-encoded URI paths. 2. Include LocationType.ZONAL_RAPID when configuring target region/zone for RCU buckets. [Generated-by: AI]
Dhriti07
reviewed
Oct 29, 2026
…adoc [Generated-by: AI]
nidhiii-27
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds location-based parameterization and backend setup to
StorageITRunnerfor Rapid Cache Ultra (RCU) integration testing:LocationTypeParameterization: AddsLocationType(US_MULTI_REGIONAL,REGIONAL_RAPID,ZONAL_RAPID) to@CrossRun,@CrossRun.Exclude,@CrossRun.Ignore,@SingleBackend, andStorageITRunner, combining class- and method-level ignore/exclude rules.DynamicBucketLifecycleinBackendResourcesandRapidCacheprovisioning/teardown inBucketInfoShim, along withPREPRODbackend support.HttpStorageRpc): Supports custom/storage/v1*service paths (e.g.,/storage/v1_preprod/) while preserving existingrootUrlbehavior for proxy paths (HttpStorageRpcUriTest).