Skip to content

chore(kokoro): fix maven shared install locking issue on osx - #14895

Open
sakthivelmanii wants to merge 4 commits into
mainfrom
chore-kokoro-maven-shared-install
Open

sakthivelmanii wants to merge 4 commits into
mainfrom
chore-kokoro-maven-shared-install

Conversation

@sakthivelmanii

Copy link
Copy Markdown
Contributor

Problem

  • Maven install on java8-osx job fails with IllegalStateException: Could not acquire lock(s).
  • Without a valid mirror on macOS runners, concurrent Central downloads stall indefinitely, causing NamedLock timeouts on dependent modules.

Solution

  • Added -Daether.connector.http.retryHandler.count=5 and -Daether.connector.requestTimeout=120000 to all Maven commands to ensure stalled transfers fail fast and release NamedLocks instead of hanging indefinitely.

Adds GCS Central mirror settings to Maven execution and configures aether timeout to fail fast on stalled network connections in order to release NamedLocks.
@sakthivelmanii
sakthivelmanii requested a review from a team as a code owner November 2, 2026 20:51
@sakthivelmanii
sakthivelmanii enabled auto-merge (squash) November 2, 2026 20:51
@sakthivelmanii

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures Maven retry and timeout options (-Daether.connector.http.retryHandler.count and -Daether.connector.requestTimeout) across several build and test steps in .kokoro/build.sh and .kokoro/common.sh. The feedback highlights multiple instances where these new options were accidentally duplicated within the same command blocks, as well as an indentation inconsistency in .kokoro/common.sh that should be corrected.

Comment thread .kokoro/build.sh Resolved
Comment thread .kokoro/build.sh Resolved
Comment thread .kokoro/build.sh Resolved
Comment thread .kokoro/common.sh Resolved
Comment thread .kokoro/common.sh Resolved
Comment thread .kokoro/common.sh Resolved

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures additional Maven properties ("-Daether.connector.http.retryHandler.count" and "-Daether.connector.requestTimeout") across several build and test commands in ".kokoro/build.sh" and ".kokoro/common.sh". However, the changes introduce redundant duplicate lines of these properties and some inconsistent indentation. The review comments correctly identify these issues and provide suggestions to clean up the formatting and remove the duplicate entries.

Comment thread .kokoro/build.sh Resolved
Comment thread .kokoro/build.sh Resolved
Comment thread .kokoro/build.sh Resolved
Comment thread .kokoro/common.sh Resolved
Comment thread .kokoro/common.sh Resolved
Comment thread .kokoro/common.sh Resolved
@sakthivelmanii

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures the Aether connector retry count and request timeout properties across several Maven invocations in the Kokoro build and common scripts to improve build reliability. The feedback suggests formatting a long Maven command in .kokoro/common.sh by splitting the options across multiple lines to improve readability and maintain consistency.

Comment thread .kokoro/common.sh Resolved
@sakthivelmanii

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures Maven HTTP retry counts and request timeouts in the Kokoro build and common scripts. However, in .kokoro/common.sh, empty lines were introduced within multi-line command continuations, which will break the Bash execution and cause "command not found" errors. These empty lines should be removed, and the indentation should be corrected to match the surrounding lines.

Comment thread .kokoro/common.sh Resolved
Comment thread .kokoro/common.sh Resolved
@sakthivelmanii

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds Aether HTTP retry and request timeout configurations to the Maven commands in .kokoro/build.sh and .kokoro/common.sh. The feedback highlights several indentation inconsistencies in the newly added lines and provides suggestions to align them with the surrounding code.

Comment thread .kokoro/build.sh Resolved
Comment thread .kokoro/common.sh Resolved
Comment thread .kokoro/common.sh Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant