Repository navigation
feat(gax): add logging to observability sample - #9786
shivanee-p wants to merge 1 commit into
Conversation
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces telemetry logging capabilities across Google Cloud Node.js client libraries, integrating it with OpenTelemetry tracing, and refactoring the core GAX client options, error utilities, and settings construction. The review feedback highlights several critical issues: constructSettings is called with arguments in the incorrect order in iamService.ts, locationService.ts, and operationsClient.ts. Additionally, potential runtime TypeError crashes were identified in gax.ts when backoff or retry is null/undefined, and in LoggerHelper.ts if loggingUtils.getNodeBackend() returns null or undefined.
e3f79b2 to
80dd1e5
Compare
danieljbruce
left a comment
danieljbruce
left a comment
There was a problem hiding this comment.
LGTM. Good to see logging isn't opt in anymore!
80dd1e5 to
4420f84
Compare
Just to document the functionality, logging is definitely still opt-in. We want to maintain that functionality. This PR specifically removes the requirement to have the |
Add logging implementation to the observability sample and remove the logging experimental flag check