Repository navigation
fix(bigquery): limit ssl error workaround to insert_rows - #18295
daniel-sanche wants to merge 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new default retry configuration specifically for streaming inserts, DEFAULT_INSERT_ROWS_RETRY, which avoids retrying on SSLError (often indicating schema mismatches in streaming inserts). Meanwhile, the standard DEFAULT_RETRY is updated to allow retrying on SSLError for other API calls. The insert_rows_json method is updated to use this new retry configuration by default and to properly handle wrapped RetryError exceptions. Corresponding unit and system tests have been added and updated. There are no review comments, so I have no feedback to provide.
daniel-sanche
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
Removed default retry assignment for insert rows.
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
…ry in system test; document DEFAULT_INSERT_ROWS_RETRY
6d34e17 to
4827fa2
Compare
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Reduces the scope of #17489. Previously, all SSLErrors were marked as non-retryable. Now, this is only the case for insert_rows requests
Fixes #18178