Repository navigation
Conversation
UnifiedJedis.pipelined() borrows a connection from the pool that is only returned when the pipeline is closed, so every ClientPoolImpl.batchEnqueue() call leaked one connection until the pool was exhausted.
UnifiedJedis.multi() also borrows a connection from the pool that is only returned when the transaction is closed, so ClientPoolImpl's recurring enqueue/removal and WorkerPoolImpl's fail queue trimming (when a FailQueueStrategy limits the max items) leaked one connection per call.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333
Since 3.0.0,
ClientPoolImpl.batchEnqueue()leaks one pooled connection per call.UnifiedJedis.pipelined()borrows a connection that onlyPipeline.close()returns, butAbstractClient.doBatchEnqueue()only callssync(). With a bounded pool, the call aftermaxTotalfails withJedisException: Could not get a resource from the pool. With the default unbounded pool config, each call leaves a connection open on Redis.UnifiedJedis.multi()has the same contract, so the same leak affects:ClientPoolImpl.recurringEnqueue()andremoveRecurringEnqueue();WorkerPoolImplfailure handling when aFailQueueStrategylimits the fail queue's max items. There the exception is caught and logged, so failures silently stop being recorded.2.x was unaffected because these calls ran inside
PoolUtils.doWorkInPool().ClientImpl/WorkerImpl(Jedis.pipelined()/multi()), closing leaves the connection open.maxTotal. They fail on master and pass with this change.