Repository navigation
fix(viewer): preserve receive statistics during redraw - #2112
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
timothyanderson096-ocdealcheck wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Scrolling or resizing the CAN viewer currently reprocesses each displayed frame as a new reception, increasing its count and resetting its receive interval. Repaint rows through the existing
sorting=Truerendering path so redraw preserves receive counts, intervals and retainedMessageobjects. Subsequent genuine receptions continue to update them normally.Related Issues / Pull Requests
Type of Change
Checklist
tox).Additional Notes
The three new regressions fail on the original implementation; all 7 viewer tests pass with the fix, including an independent rerun. They cover repeated redraw, keyboard scrolling and resize through the viewer's run loop, standard/extended IDs, message identity and subsequent genuine reception.
Configured lint, five mypy targets and strict documentation/doctests pass (
tox -e lint,type,docs,py313). The full suite reports 506 passed, 29 subtests passed, 98 skipped and 28 multicast failures. All 28 failure identities match the unchanged base: the environment has no usable multicast interface (errno 19). The all-checks checkbox remains unchecked for that reason.Curses uses the existing mocked test infrastructure. Real terminal/mouse-wheel behavior, physical CAN and the full OS/interpreter matrix were not validated. Existing byte-highlighting history is outside the count/interval/latest-message guarantee of this fix.
Tested revision:
2c18a068b63f3120895a16e76ce371ca474b8216(Linux, CPython 3.13.16).Prepared with AI assistance and reviewed independently by another agent.
Timothy Anderson — Spotted Ridge Engineering / OC Labs · GDN (Global Decision Network)
Engineering evidence