Repository navigation
fix: share ThreadSafeBus send lock with default periodic tasks - #2116
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
timothyanderson096-ocdealcheck wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Default thread-based periodic tasks call the wrapped backend directly, bypassing ThreadSafeBus.send. The null periodic context therefore permits a manual send and a periodic send, or two periodic workers, to enter backend.send concurrently.
Assign the wrapper's reentrant send lock to the backend's default periodic-task lock after initializing the send/receive locks. Preserve direct backend dispatch and separate receive locking. Add two event-controlled behavioral regressions with real VirtualBus delivery, a clarifying docstring sentence and a news fragment.
Related Issues / Pull Requests
Type of Change
Checklist
tox).Additional Notes
Validation recorded on 25 October 2026, Linux / CPython 3.13.16:
errno 19). The suite remains failing and the all-checks checkbox remains unchecked.On 27 October, public head
4fdc38364c97b79828983059d9985cd316eb714cwas recovered with full tree62abe5d4dcdaa2cebcc413648a789b7212b54f2d, exactly matching tested clean candidate97c97b4on unchanged mainb4f82ab. The saved raw tests, installed-source identities and equal full-suite failure sets were inspected again; Python/tox checks were not rerun during this publication refresh.The contract is mutual exclusion for default thread-based periodic sends, not bounded backend latency or synchronous cancellation. Independent inspection reproduced the same existing non-joining stop/post-shutdown-send limitation on base and candidate. A blocking backend send can retain the shared lock. Native/specialized periodic implementations, physical hardware and the full OS/interpreter CI matrix remain unvalidated.
Prepared with AI assistance and independently inspected during the original preparation.
Timothy Anderson — Spotted Ridge Engineering / OC Labs
Independent software verification · GDN (Global Decision Network)
timothyanderson096@gmail.com · Engineering evidence