Repository navigation
Skip install of library charts - #874
Merged
Merged
Conversation
Library charts (type: library) cannot be installed, so ct install used to fail on them. Skip the install step with a message, as suggested in the issue discussion. Linting is unchanged. Fixes helm#237 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
cpanato
approved these changes
Oct 27, 2026
cpanato
left a comment
cpanato
left a comment
Member
There was a problem hiding this comment.
Reviewed the library chart handling. The early return skips installation and upgrade testing while preserving linting, consistent with the agreed scope in #237. Verified go test ./... and go vet ./... locally, and confirmed the new regression test fails without the fix. CI is passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #237
ct install/ct lint-and-installfail on charts withtype: librarybecause helm cannot install them. As agreed in the issue discussion, the install step is now skipped for these charts with a message, whilect lintstill lints them.ChartYamlgains aTypefield.InstallChartreturns early (before the upgrade test as well) for library charts.TestInstallChart_SkipsLibraryChart(with and without--upgrade) using a library chart underpkg/chart/testdata. It panics without the change because no kubectl is configured in the mock.