Repository navigation
docs: remove unused load balancer annotations - #1404
Merged
Merged
Conversation
The ipv4, ipv6 and id annotations are neither read nor written since #933. Without them no annotation is read-only anymore, so the Read-only column is dropped from the doc generator as well.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1404 +/- ##
==========================================
+ Coverage 74.29% 74.77% +0.47%
==========================================
Files 33 33
Lines 2556 2537 -19
==========================================
- Hits 1899 1897 -2
+ Misses 657 640 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
This is not really a refactor, we are actually doing changes here, I'd rather scope it as |
lukasmetzner
changed the title
Contributor
Author
Yeah, you are right. Scoped it as |
jooola
approved these changes
Oct 28, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
ipv4,ipv6andidannotations and the now unused Read-only column from the doc generator.The controller used to copy these values from the Load Balancer onto the Service. #933 stopped that, because the
cloudprovider.LoadBalancerinterface requires implementations to treat the*v1.Serviceas read-only and not modify it. Since then, nothing reads or writes these annotations, but they stayed in the reference. The Load Balancer IPs are reported instatus.loadBalancer.ingress.