Repository navigation
Attach generated responses to live tests - #371
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR records the responses that models generate in the live provider tests as Swift Testing attachments, so they can be read after a run to check them by eye.
A new test helper,
attachResponse, attaches a text response as a.txtfile and a structured response as the.jsonthe model produced. Each attachment is named after the current test. A test that attaches more than one response adds the variable name to tell them apart. The helper is called after eachrespondcall in the Foundation Models, MLX, llama.cpp, Core ML, OpenAI, Open Responses, Anthropic, Gemini, and Ollama live suites. Streaming tests are not covered yet.Attachment.record(_:named:)is available from Swift 6.2, and the package already requires Swift tools 6.3, so the helper needs no compiler guard. Nothing underSources/changes.Resolves #93