Repository navigation
Deprecate output_type="latent" in modular decoders - #15078
Open
dhvani7014 wants to merge 4 commits into
Open
dhvani7014 wants to merge 4 commits into
dhvani7014 wants to merge 4 commits into
Conversation
Author
|
Hi @yiyixuxu, could you please review this PR whenever you get a chance? I'd really appreciate your feedback. Thank you! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yiyixuxu
reviewed
Oct 21, 2026
yiyixuxu
left a comment
Collaborator
There was a problem hiding this comment.
thanks!
i left a comment
dhvani7014
force-pushed
the
fix-15071-latent
branch
from
October 22, 2026 05:02
573e0bc to
0207a8c
Compare
Author
Author
|
Hi @yiyixuxu, just a gentle ping on this one when you have time. I switched to the deprecation as you suggested. Let me know if anything else needs changing! |
yiyixuxu
reviewed
Oct 24, 2026
Author
|
Thanks @yiyixuxu! Updated the deprecation message, removed the extra output_type check (kept just the deprecate in all the decoders), and added a line in echo.md on getting the denormalized VAE tensors without decoding. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #15071
Deprecates the
output_type == "latent"branches in the modular decode blocks for flux, sd3, sdxl, cosmos and echo, targeting removal in 0.47.0 alongside the packed-latents deprecation from #14737. Latents are available viaoutput="latents"instead. ltx2 is left for #14612.Self-review notes
output_type="latent"to these decoders still returns the latents as before, but now emits aFutureWarning(viadeprecate, 0.47.0) pointing tooutput="latents".output_typenot in ("pil", "np", "pt") raises a ValueError, same as minimax_h3.output_type="pt". Added a flux test that checks the deprecation warning and that the latents come back unchanged.test_to_devicefailures also fail on main on my Mac (MPS), so they're unrelated.Before submitting
self-reviewskill on the diff?output_type="latent"from modular decode blocks聽#15071Who can review?
@yiyixuxu