Skip to content

[core] move latent upscalers and condition embedders out of pipelines - #15111

Open
sayakpaul wants to merge 6 commits into
mainfrom
latent-up-condition-embedders
Open

sayakpaul wants to merge 6 commits into
mainfrom
latent-up-condition-embedders

Conversation

@sayakpaul

@sayakpaul sayakpaul commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Supercedes #13781.

I have verified (scripts/smoke_test_relocated_pretrained.py) that existing checkpoints load with this change. Will delete this before merging.

The new files under src/diffusers/models are basically redirections. So, reviewers can fully skip them. The changes under src/diffusers/pipelines and src/diffusers/modular_pipelines relate to deprecation and import path changes.

There's also a test tests/models/test_relocated_class_loading.py that ensures we warn about the deprecation when needed and resolve to the new class location.

@github-actions github-actions Bot added documentation Improvements or additions to documentation models tests modular-pipelines utils pipelines single-file size/L PR with diff > 200 LOC labels Oct 23, 2026
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul changed the title [core] move latent upscalers and conditionsn embedders out of pipelines [core] move latent upscalers and condition embedders out of pipelines Oct 23, 2026
@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/pipelines/ltx/test_ltx_latent_upsample.py tests/pipelines/ltx2/ tests/pipelines/ace_step/test_ace_step.py tests/pipelines/audioldm2/test_audioldm2.py tests/pipelines/stable_audio/test_stable_audio.py tests/pipelines/stable_audio_3/test_stable_audio_3.py tests/pipelines/sana_wm/test_sana_wm.py tests/modular_pipelines/ltx2/ tests/modular_pipelines/echo/ tests/models/test_relocated_class_loading.py tests/pipelines/flux/test_pipeline_flux_redux.py

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

❌ pytest tests/pipelines/ltx/test_ltx_latent_upsample.py tests/pipelines/ltx2/ tests/pipelines/ace_step/test_ace_step.py tests/pipelines/audioldm2/test_audioldm2.py tests/pipelines/stable_audio/test_stable_audio.py tests/pipelines/stable_audio_3/test_stable_audio_3.py tests/pipelines/sana_wm/test_sana_wm.py tests/modular_pipelines/ltx2/ tests/modular_pipelines/echo/ tests/models/test_relocated_class_loading.py tests/pipelines/flux/test_pipeline_flux_redux.py failed on GPU — view logs.

@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/pipelines/test_pipelines.py tests/pipelines/test_pipeline_utils.py tests/models/test_models_auto.py

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

✅ pytest tests/pipelines/test_pipelines.py tests/pipelines/test_pipeline_utils.py tests/models/test_models_auto.py passed on GPU — view logs.

@sayakpaul

Copy link
Copy Markdown
Member Author

https://github.com/huggingface/diffusers/actions/runs/39928147091 fails on main as well and has nothing related to this PR.

@sayakpaul
sayakpaul requested review from DN6 and yiyixuxu October 23, 2026 12:42
@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/models/test_relocated_class_loading.py

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

✅ pytest tests/models/test_relocated_class_loading.py passed on GPU — view logs.

Comment thread src/diffusers/models/condition_embedders/__init__.py Outdated
)


class AudioLDM2UNet2DConditionModel(ModelMixin, AttentionMixin, ConfigMixin, UNet2DConditionLoadersMixin):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit puzzling why this unet is a pipeline component
(not something we need to address in this PR)

Comment thread src/diffusers/pipelines/ltx2/connectors.py Outdated
Comment thread src/diffusers/pipelines/ace_step/modeling_ace_step.py Outdated
Comment thread src/diffusers/pipelines/ltx2/latent_upsampler.py Outdated
Comment thread src/diffusers/pipelines/pipeline_loading_utils.py Outdated
@sayakpaul
sayakpaul requested a review from yiyixuxu October 24, 2026 04:24

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation models modular-pipelines pipelines single-file size/L PR with diff > 200 LOC tests utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants