Repository navigation
Conversation
napetrov
requested review from
ethanglaser,
homksei,
mihaic and
yuejiaointel
as code owners
October 23, 2026 22:52
- cancel-in-progress only for pull_request events, so pushes to main are never cancelled by the next merge - drop -DSVS_EXPERIMENTAL_LEANVEC=YES (no such CMake option) - cibuildwheel: pull_request paths filter - core builds: ignore CODEOWNERS, dependabot, unrelated workflows, LICENSE, THIRD-PARTY-PROGRAMS
setup.py reads README.md, LICENSE and THIRD-PARTY-PROGRAMS from the repo root, and the cpp runtime conda recipe packages LICENSE and THIRD-PARTY-PROGRAMS. The new path filter and paths-ignore skipped those changes, so a rename or removal would only fail after merge.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three CI hygiene fixes in
.github/workflows/. Refs #432, #436.cancel-in-progress: ${{ github.event_name == 'pull_request' }}(group keys unchanged)cancel-in-progress: truemainis no longer cancelled when the next commit lands. PR runs still cancel superseded runs.-DSVS_EXPERIMENTAL_LEANVEC=YESbuild-linux-arm.yml,build-macos.yamlpull_request.pathsfiltercibuildwheel.ymlbindings/python/**,include/**,cmake/**,CMakeLists.txt,data/**,docker/x86_64/manylinux228/**,examples/python/**,tools/pybuild.py,README.md,LICENSE,THIRD-PARTY-PROGRAMS, or the workflow itself. Push tomainstays unfiltered.paths-ignorebuild-linux,build-linux-arm,build-macos,build-cpp-runtime-bindings,build-c-api-bindings.github/CODEOWNERS,.github/dependabot.yml,.github/workflows/cibuildwheel.yml,.github/workflows/skywalking-eyes.yml.LICENSE*andTHIRD-PARTY-PROGRAMSare skipped forbuild-linux,build-linux-arm,build-macosandbuild-c-api-bindingsonly: none of those read them.build-cpp-runtime-bindingskeeps them, since its conda recipe packages both files.Evidence
mainwere cancelled when f3fb5bd landed, so 01faed1 was never tested. With the new setting,cancel-in-progressis false forpushevents.grep -rn SVS_EXPERIMENTAL_LEANVEC cmake/ CMakeLists.txt bindings/finds nothing; onlyHISTORY.mdmentions it. CMake warns about it on every ARM run (run 40030763524):bindings/python/CMakeLists.txtdoesadd_subdirectory("../.."), which pulls in the rootCMakeLists.txt,cmake/andinclude/. It also installsdata/serialization.toml. The tests readdata/test_dataset. The workflow buildsdocker/x86_64/manylinux228and runstools/pybuild.pyandexamples/python. All of those paths are in the filter.examples/is not ignored.docker/**is not ignored either.main; there are no new findings.Merge danger
mainthat land back to back no longer cancel a run that is already going, so a burst of merges uses more runner minutes. GitHub still replaces a run that is only pending with a newer one, so a middle commit of a quick burst can get no run; that is unchanged by this PR..github/files before, so check branch protection if that matters.🤖 Generated with Claude Code