Skip to content

ci: drop Linux ivf=OFF RelWithDebInfo jobs, a subset of the ivf=ON ones #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
napetrov wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: drop Linux ivf=OFF RelWithDebInfo jobs, a subset of the ivf=ON ones #452

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dc7a4b
ci: drop Linux ivf=OFF RelWithDebInfo jobs, a subset of the ivf=ON ones
napetrov Oct 23, 2026
d4f3415
ci: say which job guards the no-MKL build in the ivf=OFF exclude comment
napetrov Oct 26, 2026
6a6cb0e
Merge remote-tracking branch 'origin/main' into dev/napetrov/ci-drop-…
napetrov Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,17 @@ jobs:
-DSVS_BUILD_EXAMPLES=NO
# skip longer-running tests
ctest_args: -LE long
# ivf=OFF RelWithDebInfo is a strict subset of ivf=ON for the same
# compiler (IVF only appends sources and links MKL; no non-IVF source
# includes MKL headers). g++-12 keeps ivf=OFF as its only job, and
# clang++-18 ASAN keeps the no-MKL build covered.
Comment on lines +69 to +72

@ethanglaser ethanglaser Oct 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# ivf=OFF RelWithDebInfo is a strict subset of ivf=ON for the same
# compiler (IVF only appends sources and links MKL; no non-IVF source
# includes MKL headers). g++-12 keeps ivf=OFF as its only job, and
# clang++-18 ASAN keeps the no-MKL build covered.

exclude:
- cxx: g++-12
ivf: ON
- cxx: g++-11

@ethanglaser ethanglaser Oct 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- cxx: g++-11
# skip redundant IVF=off runs which are a strict subset of ivf=ON
- cxx: g++-11

ivf: OFF
- cxx: clang++-15
ivf: OFF

steps:
- uses: actions/checkout@v6
Expand Down
Loading