Repository navigation
fix: allow YouTube, Vimeo and Canva frames in sandbox app - #2803
Merged
Sunilsbcloud merged 1 commit intoOct 19, 2026
Merged
Conversation
Activity embeds were blocked because frame-src was missing and fell back to default-src 'self'. The nonce and strict-dynamic script-src control is unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
Sunilsbcloud
enabled auto-merge (squash)
October 19, 2026 04:37
shawnm0705
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jira: CORE-8421 (related to CORE-8392).
Learner activity embeds for YouTube, Vimeo, and Canva are blocked on
https://app.p2-sandbox.practera.com. The enforcing sandbox CSP has noframe-src, so the browser falls back todefault-src 'self'and blocks those frames. The report-only policy logs the same gap but does not block it.This PR adds one sandbox directive:
https://www.youtube-nocookie.comis included because Plyr is configured withyoutube.noCookie: true.PR #2797 stays intact.
script-srcis stillnonce-<per-deploy> 'strict-dynamic' 'unsafe-inline' 'self' https://acsbapp.com. These media hosts are not added toscript-srcorconnect-src. The shared report-only CSP template is unchanged.The accessiBe config fetch to
https://cdn.acsbapp.comremains a separateconnect-srcissue and is not part of this PR.Test plan
node scripts/assert-app-csp.cjspassed. It locks the newframe-srcallowlist, rejects a wildcard in that directive, and checks that YouTube, Vimeo, and Canva are absent fromscript-srcandconnect-src. It also checks that the nonce and'strict-dynamic'still apply to the sandbox template and to every sample script tag.content-security-policyheader still contains the per-deploy nonce and'strict-dynamic', and that the HTML script nonce matches.cdn.acsbapp.comconnect failure is unchanged.Made with Cursor