Repository navigation
fix(rtl): respect dir of ancestor elements throughout components - #31459
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OS-jacobbell
changed the title
dir setting of ancestor elements throughout components
OS-jacobbell
changed the title
dir setting of ancestor elements throughout componentsdir of ancestor elements throughout components
ShaneK
requested changes
Sep 22, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Nice sweep of this! Just a few comments inline, though I'd want the test coverage added before it goes in.
Co-authored-by: Shane <shane.king@outsystems.com>
OS-jacobbell
commented
Sep 24, 2026
OS-jacobbell
commented
Sep 24, 2026
OS-jacobbell
commented
Sep 24, 2026
ShaneK
requested changes
Sep 28, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Thanks for adding the tests and taking the suggestions! Most of them pass on main too though, so they aren't covering the change yet, and CI is red on the new popover one. I've left comments inline.
ShaneK
requested changes
Oct 15, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Really close! Just a few more comments inline.
ShaneK
approved these changes
Oct 20, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Looks great, thanks for sticking with this one! Just need the datetime test fixed so lint passes. 🚀
Co-authored-by: Shane <shane.king@outsystems.com>
brandyscarney
requested changes
Oct 21, 2026
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Looking good! Requested changes for the popover direction regression on popover.tsx. The other comments are non-blocking.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Some components check
document.dir === 'rtl'to determine whether to be left-to-right or right-to-left.What is the new behavior?
isRTL(this.el). This way, any element in the parent chain can define RTL, not just the root document element.isRTL.Does this introduce a breaking change?