Repository navigation
Conversation
thetaPC
added this pull request to stack #31538
October 6, 2026 22:11
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
approved these changes
Oct 15, 2026
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
I have added some questions / comments but I am approving this as you can tell me if you disagree on any or all.
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
thetaPC
force-pushed
the
FW-6863-tests
branch
from
October 20, 2026 02:47
5f572a1 to
b365e48
Compare
brandyscarney
approved these changes
Oct 21, 2026
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
This looks good just some minor test change requests!
Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
No test sets
coloronion-title, and no test screenshots a title in the ionic theme in RTL.What is the new behavior?
colortest page and screenshots in the ionic, md and ios themes.basicscreenshots in RTL too. The ios and md RTL snapshots already existed without a test generating them; they now have one..toolbar-titleelement the iOS large title animations measure, and theionStyleevent.Does this introduce a breaking change?
Other information