Repository navigation
Point the EULA references to the Palo Alto Networks EULA - #852
Merged
Merged
Conversation
The image license annotations and the disco-agent chart's acceptTerms notice linked to https://www.cyberark.com/contract-terms/. Point them to the Palo Alto Networks EULA instead.
wallrj-cyberark
self-requested a review
October 29, 2026 10:55
wallrj-cyberark
left a comment
wallrj-cyberark
left a comment
Contributor
There was a problem hiding this comment.
The URL changes are correct. Please also update the acceptTerms description, which still says "the CyberArk Terms of Service":
deploy/charts/disco-agent/values.yaml:8deploy/charts/disco-agent/README.md:177anddeploy/charts/disco-agent/values.schema.json:98, which are generated from that comment
With this PR, the install-time notice sends users to the Palo Alto Networks EULA, so the chart would describe the same value in two different ways. Please change the comment to name the EULA, then regenerate the README and schema with make generate-helm-docs generate-helm-schema.
The disco-agent chart's install notice now links to the Palo Alto Networks EULA, but the acceptTerms description still said "the CyberArk Terms of Service". Update the comment and regenerate the README and values schema with helm-tool. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj-cyberark
approved these changes
Oct 30, 2026
wallrj-cyberark
left a comment
wallrj-cyberark
left a comment
Contributor
There was a problem hiding this comment.
The URL changes are correct, and I've pushed 491dbd4 to update the acceptTerms description and regenerate the README and schema. test and verify pass. Thanks, Karan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image license annotations and the disco-agent chart's
acceptTermsnotice still link tohttps://www.cyberark.com/contract-terms/. This PR points them to the Palo Alto Networks EULA:https://www.paloaltonetworks.com/content/dam/pan/en_US/assets/pdf/legal/palo-alto-networks-end-user-license-agreement-eula.pdf
What changes
make/00_mod.mkandmake/ark/00_mod.mk: theorg.opencontainers.image.licensesimage annotation.deploy/charts/disco-agent/templates/deployment.yaml: the URL in the "Terms & Conditions Notice" shown whenacceptTermsisn't set.No behaviour changes; only the URL text.
Testing
helm-unittestpasses for the disco-agent, venafi-kubernetes-agent and discovery-agent charts (103 tests, 14 snapshots).@wallrj could you take a look?