Repository navigation
Fix non-admin ApplicationCredential deletion - #1028
Merged
Merged
Conversation
mandre
force-pushed
the
fix-appcreds-deletion
branch
from
October 28, 2026 09:34
aeb3d6d to
252d314
Compare
Resolve managed credential owners through `resource.userRef` and query Keystone directly under that user. A deleted credential now returns 404 without falling back to user enumeration, whose 403 response prevented finalizer removal for non-admin users. Preserve discovery for imports and propagate direct lookup errors. Add client and actuator tests, regenerate the client mock, and cover deletion with a non-admin KUTTL regression test. Fixes k-orc#1022.
mandre
force-pushed
the
fix-appcreds-deletion
branch
from
October 28, 2026 10:19
252d314 to
010572c
Compare
winiciusallan
approved these changes
Oct 29, 2026
winiciusallan
left a comment
winiciusallan
left a comment
Member
There was a problem hiding this comment.
Nice! We have regression tests for that case following how to reproduce, and they're all green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve managed credential owners through
resource.userRefand query Keystone directly under that user. A deleted credential now returns 404 without falling back to user enumeration, whose 403 response prevented finalizer removal for non-admin users.Preserve discovery for imports and propagate direct lookup errors. Add client and actuator tests, regenerate the client mock, and cover deletion with a non-admin KUTTL regression test.
Fixes #1022.